mlpack IRC logs, 2018-06-24
Logs for the day 2018-06-24 (starts at 0:00 UTC) are shown below.
--- Log opened Sun Jun 24 00:00:17 2018
05:48 -!- haritha1313 [0e8bf0fb@gateway/web/freenode/ip.18.104.22.168] has joined #mlpack
05:50 < haritha1313> zoq: Looks like those two were independent issues. I did solve the submat() error and have pushed the changes. But adding concat layer to FFN still gives the error I mentioned yesterday. Was it the same for you when you tested it? If the error wasn't reproduced it could be some mistake with the network I created, although its working perfectly fine for MultiplyMerge.
06:51 -!- ImQ009 [~ImQ009@unaffiliated/imq009] has joined #mlpack
07:12 -!- haritha1313 [0e8bf0fb@gateway/web/freenode/ip.22.214.171.124] has quit [Ping timeout: 260 seconds]
07:27 -!- witness_ [uid10044@gateway/web/irccloud.com/x-adrhbgjhkxlenzsp] has quit [Quit: Connection closed for inactivity]
10:17 -!- vivekp [~vivek@unaffiliated/vivekp] has joined #mlpack
10:29 -!- vivekp [~vivek@unaffiliated/vivekp] has quit [Ping timeout: 256 seconds]
10:32 -!- vivekp [~vivek@unaffiliated/vivekp] has joined #mlpack
10:56 -!- vivekp [~vivek@unaffiliated/vivekp] has quit [Ping timeout: 264 seconds]
10:57 -!- vivekp [~vivek@unaffiliated/vivekp] has joined #mlpack
13:14 < zoq> haritha1313: It looks like the output dimensions for the subview layer are strange, for: (endRow - beginRow + 1) * (endCol - beginCol + 1) I get 18446744073709551607 (second layer), also I used https://gist.github.com/zoq/e702cff47a4ababcdcaae8addc95569c as the network (note the new for the Concat layer).
13:14 < zoq> haritha1313: Perhaps it's already fixed?
16:30 -!- vivekp [~vivek@unaffiliated/vivekp] has quit [Ping timeout: 255 seconds]
16:47 -!- haritha1313 [0e8bf0fb@gateway/web/freenode/ip.126.96.36.199] has joined #mlpack
16:50 < haritha1313> zoq: Well the issue I have already solved was caused by beginCol and endCol being modified in the loop in Forward(). So probably you won't get the wrong dimension with the latest code in #1435. But if its something I am missing do let me know.
16:50 < haritha1313> Thanks for your help with the concat issue. :)
17:03 < zoq> haritha1313: hm, I'm using the latest version.
17:05 < haritha1313> Oh, I'll look into it then.
17:06 < zoq> haritha1313: Did you build the code with -DDEBUG=ON?
17:06 < haritha1313> No, I didn't.
17:06 < haritha1313> I'll try that.
17:07 < zoq> haritha1313: That could be the issue, if DEBUG=OFF which is the default, all bounding checks are disabled.
17:08 < zoq> Currently I use: 'cmake -DBUILD_CLI_EXECUTABLES=OFF -DDEBUG=ON -DBUILD_PYTHON_BINDINGS=OFF ..'
17:10 < haritha1313> Building again with these parameters. I'll try to debug this soon.
17:10 < zoq> okay, sounds good
17:10 < haritha1313> I also had a doubt regarding the concat merge.
17:10 < haritha1313> .The intuition is that it concatenates each vector (sample) of the matrix to corresponding vector of another matrix. So if I give input of two 10X10 matrices I can expect a 20X10 matrix as output. Am I right?
17:11 < zoq> yes, that is correct
17:13 < haritha1313> I tried to find out the output matrix's dimension when using it in the network and was getting 100X2. So it got a bit confusing.
17:16 < zoq> Right, the Concat layer will vectorize the calculated output for each subnetwork, so if the output for the first network is of size 10 * 10, it will be transformed into a vector of 100 * 1.
17:19 < zoq> I guess, we would have to write another layer that flattens the input?
17:20 < zoq> Or we introduce a new parameter that does this for us.
17:26 < zoq> Should this be:
17:26 < zoq> (beginRow - endRow + 1) * (beginCol - endCol + 1)
17:26 < zoq> instead of
17:26 < zoq> (endRow - beginRow + 1) * (endCol - beginCol + 1)
17:26 < zoq> so that we don't get a negative value if endRow = 0?
17:26 < haritha1313> Regarding concat, I don't think it will be a problem here since the embedding was meant to be flattened anyway. And I was planning to use linear layer with outSize 1 for flattening.
17:27 < zoq> if that works, good :)
17:29 < haritha1313> If we use (beginRow - endRow + 1), isn't there more chances of beginRow being 0, it being the smaller index?
17:31 < haritha1313> Maybe we can just check if endRow >= beginRow and endCol >= beginCol
17:31 < zoq> In the example I used is: endRow = 0 (default), beginRow = 10 (user defined) which is currently -11
17:32 < zoq> for the first part: (endRow - beginRow + 1)
17:32 < zoq> we could use std::abs
17:34 < haritha1313> Yes, that should solve the size issue. But would there be any meaning of having a subview from 10 to 0?
17:36 < zoq> I think you could constuct a case yes, but in this case the user specified the worng parameeter, there is probably a way we could use to avoid both issue.
17:38 < haritha1313> I think it might be better if we set endRow = input.n_rows - 1 if endRow < beginRow and similar for column.
17:38 < zoq> yeah, that should work :)
17:40 < haritha1313> I'll add that condition then. Also, didn't have any trouble with DEBUG=ON.
17:40 < zoq> what is the output of: (endRow - beginRow + 1) * (endCol - beginCol + 1) in your case?
17:41 < haritha1313> For the example of beginRow = 10 and endRow = 0?
17:42 < zoq> yes, I used: std::cout << "rows: " << (endRow - beginRow + 1) * (endCol - beginCol + 1) << std::endl; right after
17:42 < zoq> output.set_size(
17:42 < zoq> (endRow - beginRow + 1) * (endCol - beginCol + 1), batchSize);
17:42 < haritha1313> That would give a row size of 10 since endRow will be set to 19 for a matrix of size (20,1)
17:43 < zoq> in the updated case, right?
17:44 < haritha1313> Yes
17:45 < haritha1313> I changed line 74, 75 to endRow = ((endRow < input.n_rows) && (endRow >= beginRow)) ? endRow : (input.n_rows - 1); endCol = ((endCol < inSize) && (endCol >= beginCol)) ? endCol : (inSize - 1);
17:45 < zoq> okay, I was talking about the current code.
17:46 < haritha1313> In current code as you said it will go to negative, it would give -9 possibly.
17:46 < zoq> right
17:46 < zoq> Does this solve the issue you see on your side?
17:47 < haritha1313> I think this should solve it.
18:48 < haritha1313> zoq: The new condition does work for the 10, 0 case too :) .
18:49 -!- haritha1313 [0e8bf0fb@gateway/web/freenode/ip.188.8.131.52] has quit [Quit: Page closed]
20:14 -!- ImQ009 [~ImQ009@unaffiliated/imq009] has quit [Quit: Leaving]
21:20 < jenkins-mlpack> Project docker mlpack nightly build build #359: STILL UNSTABLE in 14 hr: http://masterblaster.mlpack.org/job/docker%20mlpack%20nightly%20build/359/
21:44 -!- James [d57f4ef4@gateway/web/freenode/ip.184.108.40.206] has joined #mlpack
21:44 -!- James is now known as Guest82786
21:45 -!- Guest82786 [d57f4ef4@gateway/web/freenode/ip.220.127.116.11] has left #mlpack